Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #77

Merged
aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor
Nov 17, 2026
Merged

aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook (--no-online-audits).
  • images-creator.yml brought zizmor-clean with the auditor persona (zizmor --no-online-audits --persona=auditor):
    • all actions pinned to commit SHAs (checkout, docker actions)
    • persist-credentials: false on checkouts (artipacked)
    • workflow permissions minimized (excessive-permissions)
    • concurrency group (concurrency-limits) and job names (anonymous-definition)

zizmor v1.32.0 reports no findings with both the default and the auditor persona.

@fstagni
fstagni marked this pull request as ready for review November 15, 2026 14:17
- the workflow-level contents: read left the GITHUB_TOKEN without
  packages: write, so both ghcr.io pushes would be denied; grant it on
  the two jobs that push
- push el9-dirac on every non-PR run on master, so the weekly schedule
  (and manual runs) keep publishing el9-dirac:latest with the OS updates
- only PR runs are cancelled by a newer push, never a publishing run
- default_language_version python3: the zizmor hook needs no exact 3.11

Assisted-by: Claude:claude-opus-5-5
@aldbr
aldbr merged commit a719712 into DIRACGrid:master Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants