Skip to content

ci: run all pre-commit hooks in CI and rely on Renovate for hook updates - #1193

Open
fstagni wants to merge 1 commit into
DIRACGrid:mainfrom
fstagni:replace-precommit-ci
Open

fstagni wants to merge 1 commit into
DIRACGrid:mainfrom
fstagni:replace-precommit-ci

Conversation

@fstagni

@fstagni fstagni commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Part of DIRACGrid/.github#5.

Replaces the pre-commit.ci app with the org-standard setup (same pattern as intercede/signurlarity/diracx-charts):

  • a pre-commit job running all pre-commit-stage hooks via pre-commit/action, with pre-commit-ci/lite-action pushing auto-fixes to PR branches (the UX the app used to provide)
  • the 4 pixi-dependent local hooks (generate-pixi-docs, settings-doc-check, check-all-required, check-all-forbidden) move to stages: [manual] and keep running in the pixi-based job with --hook-stage manual — the ci.skip section (pre-commit.ci-only) is removed
  • hook rev updates come from Renovate's pre-commit manager, enabled org-wide in chore: enable Renovate's pre-commit manager in the shared preset .github#8 (weekly [pre-commit.ci] pre-commit autoupdate PRs used to do this)

Once this is in, the pre-commit.ci app can be uninstalled from the repository (it currently has write access to push to PR branches).

Note for reviewers: conventional-pre-commit (commit-msg stage) is no longer run in CI — PR/commit message conventions were already enforced by pr-title.yml, which is what survives squash-merge.

Replace the pre-commit.ci app (which ran the hooks on PRs and posted the
autoupdate PRs) with the org-standard setup:
- a pre-commit job running all the pre-commit-stage hooks via
  pre-commit/action, auto-fixing PRs via pre-commit-ci/lite-action
  (same pattern as intercede/signurlarity/diracx-charts)
- the pixi-dependent local hooks move to stages: [manual] and keep
  running in the pixi-based job (with --hook-stage manual), so the
  ci.skip section is no longer needed
- hook rev updates come from Renovate's pre-commit manager, enabled
  org-wide in DIRACGrid/.github#8

The pre-commit.ci app can be uninstalled from the repository once this
is in.

Part of DIRACGrid/.github#5.
aldbr added a commit to fstagni/diracx that referenced this pull request Nov 17, 2026
DIRACGrid#1193 already replaces the pre-commit.ci app; keep this
PR to the Renovate preset.

Assisted-by: Claude:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant