Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #5

Merged
fstagni merged 2 commits into
DIRACGrid:mainfrom
fstagni:zizmor-auditor
Nov 16, 2026
Merged

fstagni merged 2 commits into
DIRACGrid:mainfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

Part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook (--no-online-audits).
  • gh-pages.yml brought zizmor-clean with the auditor persona (zizmor --no-online-audits --persona=auditor):
    • all actions pinned to commit SHAs (checkout, setup-python, upload-pages-artifact, deploy-pages)
    • persist-credentials: false on checkout (artipacked)
    • pages: write/id-token: write moved from the workflow level to the deploy job, with comments (excessive-permissions)
    • job names (anonymous-definition)

zizmor v1.32.0 reports no findings with both the default and the auditor persona.

@fstagni
fstagni marked this pull request as ready for review November 15, 2026 14:17
@fstagni
fstagni merged commit bfb83a3 into DIRACGrid:main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant