Repository navigation
feat: run the pylint job with pixi - #824
Merged
Merged
Conversation
Align the pattern with DIRACGrid/DIRAC's semantic.yml, which accepts chore: commits.
Port of DIRACGrid#822 to the integration branch: the pyLint job drops setup-micromamba + DIRAC's environment.yml in favor of a locked pixi environment (pixi.toml mirrors DIRAC integration's environment.yml; exclude-newer enforces the 7-day release-age cooldown at solve time). DIRAC@integration is installed editable with --no-deps so that import DIRAC resolves for pylint.
aldbr
previously approved these changes
Nov 16, 2026
On DIRAC's integration branch the utilities re-exported by DIRAC.Core.Utilities (fromString, toEpoch, fromChar, uniqueElements, ...) live in the dirac-common subpackage (DIRACCommon). Without it pylint cannot resolve the star-import re-exports and reports E1101/E0611. Install both packages editable and use the generic SETUPTOOLS_SCM_PRETEND_VERSION so both get a version from the depth-1 checkout. Verified locally: pylint -E exits 0.
- .gitignore: anchor DIRAC/, .DIRAC/ and .pixi/ to the repository root; the unanchored DIRAC/ also ignored the tracked src/WebAppDIRAC/WebApp/static/DIRAC/ tree (new apps were silently left out of commits). - deployment: give workflow_dispatch releases their own concurrency group. With a shared group, a later push/PR run replaced a queued release (GitHub keeps only one pending run per group). - codestyle: only cancel in-progress runs for pull requests, so every commit pushed to a protected branch gets a CI result. - codestyle: install DIRAC with --no-build-isolation; the build backends (setuptools, setuptools-scm, wheel, hatchling, hatch-vcs) now come from pixi.lock instead of unpinned PyPI downloads outside the cooldown. - codestyle: use a neutral 0.0.0 SCM placeholder version (the shallow checkout has no tags, pylint ignores the value) and re-enable the setup-pixi cache keyed on pixi.lock. - pixi.toml: matplotlib -> matplotlib-base, so the conda tornado is no longer installed under the tornado fork from PyPI (also drops Qt); refresh the header comment (editable install, not a copy). Assisted-by: Claude:claude-opus-5-5
aldbr
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #822 to the integration branch, stacked on #820 (part of DIRACGrid/.github#5, adopt
pixieverywhere).The
pyLintjob ofcodestyle.ymldropssetup-micromamba+ DIRAC'senvironment.ymlin favor of a locked pixi environment:pixi.toml: the dependency set mirrors DIRAC'senvironment.ymlon theintegrationbranch (which this branch lints against), minus the heavyrucio-clients(not needed forpylint -E), pluspylintitself.pixi.lockis committed: the environment is reproducible, and Renovate (via the org preset) becomes the only path for dependency changes.exclude-newer = "7d"in the workspace config: per the org policy in chore: add the shared DIRACGrid Renovate config preset .github#7, the release-age cooldown is enforced by the solver at lock time (Renovate's lockfile maintenance skipsminimumReleaseAge).integration) is checked out and installed editable with--no-depsso thatimport DIRACresolves for pylint; dependencies come from the pixi environment.Verified locally:
pixi locksolves andpixi run pylint --versionruns (pylint 4.1.3, Python 3.11.18).