Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #291

Merged
fstagni merged 1 commit into
DIRACGrid:develfrom
fstagni:zizmor-auditor
Nov 16, 2026
Merged

fstagni merged 1 commit into
DIRACGrid:develfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook (--no-online-audits).
  • All workflows brought zizmor-clean with the auditor persona (zizmor --no-online-audits --persona=auditor):
    • all actions pinned to commit SHAs (checkout, cvmfs action, gsactions/commit-message-checker, upload-artifact)
    • the python container images of the test matrix are pinned to sha256 digests, passed through the matrix (unpinned-images)
    • persist-credentials: false on all checkouts (artipacked)
    • workflow/job permissions minimized (excessive-permissions)
    • concurrency groups (concurrency-limits) and job names (anonymous-definition)
    • matrix template expansions in run: blocks moved to env (template-injection)
  • Documented suppressions: HOSTCERT_BASE64/HOSTKEY_BASE64 (secrets-outside-env) — fork-level test certificates, no GitHub environment exists for them; gsactions/commit-message-checker (archived repo, pinned)

zizmor v1.32.0 reports no findings with both the default and the auditor persona.

@fstagni
fstagni marked this pull request as ready for review November 15, 2026 14:17
@fstagni
fstagni changed the base branch from master to devel November 16, 2026 11:15
@fstagni
fstagni merged commit dea6672 into DIRACGrid:devel Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant