Repository navigation
Conversation
39 of 61 tasks
Running the matrix command via an unquoted $COMMAND env var loses the shell quoting of e.g. -k 'not test_BaseType_Unicode and not test_nestedStructure': pytest receives the quote characters literally and treats test_BaseType_Unicode as a missing file path, exiting with code 4. Use eval "$COMMAND" to re-parse the quoting, keeping the zizmor template-injection fix intact.
fstagni
force-pushed
the
zizmor-auditor-rel-v8r0
branch
from
November 16, 2026 10:24
ffdb639 to
b95d19f
Compare
This was referenced Nov 16, 2026
Quoting "$MATRIX_ARGS" passes the whole space-separated KEY=VALUE list
as a single argument, so integration_tests.py's split('=', 1) puts
e.g. 'mariadb:10.6.3 ES_VER=opensearchproject/opensearch:2.1.0' into
MYSQL_VER and docker compose fails with 'invalid reference format'.
Leave $MATRIX_ARGS unquoted so the shell word-splits it into separate
flags, as the original ${{ matrix.ARGS }} expansion did.
fstagni
marked this pull request as ready for review
November 16, 2026 16:22
The pylint-py27 job was already removed upstream (DIRACGrid#8895); take that removal to resolve the conflict with the zizmor changes.
fstagni
force-pushed
the
zizmor-auditor-rel-v8r0
branch
from
November 17, 2026 12:12
46f0396 to
c67ed9e
Compare
This was referenced Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8887 (rel-v8r0), part of DIRACGrid/.github#5 (add
zizmoreverywhere as pre-commit), same as DIRACGrid/intercede#43 and #8891 (integration).--no-online-audits).zizmor --no-online-audits --persona=auditor):persist-credentials: falsewhere no push happens (artipacked); the deployment checkout keeps the PAT persisted credentials (documented zizmor ignore) because the release notes commit is pushed to the protected release branchpermissionsminimized (excessive-permissions)run:blocks moved toenv(template-injection)CVMFS_PROXY_BASE64(no GitHub environment exists for the CVMFS upload), the deployment PAT (needed for the protected-branch push),gsactions/commit-message-checker(archived repo, pinned)zizmor v1.32.0now reports no findings with both the default and the auditor persona.