Skip to content

[v9r0] chore: add zizmor (pre-commit) and fix its auditor findings - #8892

Open
fstagni wants to merge 3 commits into
DIRACGrid:rel-v9r0from
fstagni:zizmor-auditor-rel-v9r0
Open

fstagni wants to merge 3 commits into
DIRACGrid:rel-v9r0from
fstagni:zizmor-auditor-rel-v9r0

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Stacked on #8888 (rel-v9r0), part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43 and #8891 (integration).

  • pre-commit: zizmor hook (--no-online-audits).
  • All workflows brought zizmor-clean with the auditor persona (zizmor --no-online-audits --persona=auditor):
    • all actions pinned to commit SHAs
    • persist-credentials: false where no push happens (artipacked); the deployment checkout keeps the PAT persisted credentials (documented zizmor ignore) because the release notes commit is pushed to the protected release branch
    • workflow/job permissions minimized (excessive-permissions)
    • concurrency groups (concurrency-limits) and job names (anonymous-definition)
    • template expansions in run: blocks moved to env (template-injection)
  • Documented suppressions: CVMFS_PROXY_BASE64 (no GitHub environment exists for the CVMFS upload), the deployment PAT (needed for the protected-branch push), gsactions/commit-message-checker (archived repo, pinned)

zizmor v1.32.0 now reports no findings with both the default and the auditor persona.

@fstagni
fstagni force-pushed the zizmor-auditor-rel-v9r0 branch from 708fc45 to 22d1181 Compare November 16, 2026 10:00
@fstagni fstagni changed the title chore: add zizmor (pre-commit) and fix its auditor findings [v9r0] chore: add zizmor (pre-commit) and fix its auditor findings Nov 16, 2026
The plain $COMMAND expansion word-splits without quote removal, so the
pytest -k 'not test_BaseType_Unicode and not test_nestedStructure'
expression is broken into separate arguments and pytest fails with
'file or directory not found: test_BaseType_Unicode'.
Use eval "$COMMAND" to re-parse the quoting, as already done on the
v8r0 branch.
@fstagni
fstagni force-pushed the zizmor-auditor-rel-v9r0 branch from 3cdceeb to 304f3a0 Compare November 16, 2026 14:29
Quoting "$MATRIX_ARGS" passes the whole space-separated KEY=VALUE list
as a single argument, so integration_tests.py's split('=', 1) puts
e.g. 'mariadb:10.6.3 ES_VER=opensearchproject/opensearch:2.1.0' into
MYSQL_VER and docker compose fails with 'invalid reference format'.
Leave $MATRIX_ARGS unquoted so the shell word-splits it into separate
flags, as the original ${{ matrix.ARGS }} expansion did.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant