Repository navigation
chore: add zizmor (pre-commit) and fix its auditor findings - #19
Merged
Merged
Conversation
39 of 61 tasks
…drop skip-duplicate-actions (removed in DIRACGrid#18)
fstagni
marked this pull request as ready for review
November 16, 2026 16:25
…gress - 2.7.18 and 3.6.15 were pinned to their amd64 image, not the multi-arch index like 3.9.17 and 3.11.4; pin all four as python:<tag>@<index digest> so the digest is readable as a version - define the image matrix once (YAML anchor) so pytest and pylint cannot drift - drop the if: conditions: the workflow only runs on pull_request, so they were always true - zizmor hook: keep its --no-progress, which args would otherwise replace (zizmor#582) - pypi-publish: say what cancel-in-progress: false does and does not guarantee Assisted-by: Claude:claude-opus-5-5
aldbr
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, part of DIRACGrid/.github#5 (add
zizmoreverywhere as pre-commit), same as DIRACGrid/intercede#43.--no-progress --no-online-audits, same as DIRACGrid/.github).zizmor --no-online-audits --persona=auditor):persist-credentials: falseon all checkouts (artipacked)permissionsminimized (excessive-permissions)python:<version>@<multi-arch index digest>(unpinned-images), with the matrix defined once and shared by pytest and pylint (YAML anchor)if:conditions removed (the workflow only runs onpull_request)zizmor v1.32.0now reports no findings with both the default and the auditor persona.