Skip to content

chore: add zizmor (pre-commit) and fix its auditor findings - #19

Merged
aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor
Nov 17, 2026
Merged

aldbr merged 3 commits into
DIRACGrid:masterfrom
fstagni:zizmor-auditor

Conversation

@fstagni

@fstagni fstagni commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #18, part of DIRACGrid/.github#5 (add zizmor everywhere as pre-commit), same as DIRACGrid/intercede#43.

  • pre-commit: zizmor hook (--no-progress --no-online-audits, same as DIRACGrid/.github).
  • Both workflows brought zizmor-clean with the auditor persona (zizmor --no-online-audits --persona=auditor):
    • actions pinned to commit SHAs (checkout, setup-python)
    • persist-credentials: false on all checkouts (artipacked)
    • workflow/job permissions minimized (excessive-permissions)
    • job names (anonymous-definition) and concurrency groups (concurrency-limits)
    • the python container images of the test matrix are pinned as python:<version>@<multi-arch index digest> (unpinned-images), with the matrix defined once and shared by pytest and pylint (YAML anchor)
    • the always-true if: conditions removed (the workflow only runs on pull_request)
  • zizmor v1.32.0 now reports no findings with both the default and the auditor persona.

@fstagni
fstagni marked this pull request as ready for review November 16, 2026 16:25
…gress

- 2.7.18 and 3.6.15 were pinned to their amd64 image, not the multi-arch
  index like 3.9.17 and 3.11.4; pin all four as python:<tag>@<index digest>
  so the digest is readable as a version
- define the image matrix once (YAML anchor) so pytest and pylint cannot drift
- drop the if: conditions: the workflow only runs on pull_request, so they
  were always true
- zizmor hook: keep its --no-progress, which args would otherwise replace
  (zizmor#582)
- pypi-publish: say what cancel-in-progress: false does and does not guarantee

Assisted-by: Claude:claude-opus-5-5
@aldbr
aldbr merged commit 1b15e0d into DIRACGrid:master Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants