Repository navigation
GitHub Actionsで固定Harnessから既存の検証を実行する - #20
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PRとmainの更新時に、ローカルと同じProject ProfileをGitHub Actionsで実行するCIを追加します。
非公開の共通Harnessは、MiniFlowが追跡する固定SHAと専用の読み取り権限で取得します。
認証情報が未設定の場合は検証を省略せず失敗します。現在は設定待ちのため、CI全体の成功は未確認です。
変更内容
actions/checkoutとactions/setup-nodeを公式の固定SHAで使用します。読み取り権限、credential非永続化、20分上限、cacheなしで実行します。.gitmodulesの任意URLを使わず、固定repositoryのgitlinkと同じSHAを取得します。形式検証は本番helperと16件の単体試験で確認します。検証
設定待ちとマージ条件
Actions repository secret
HARNESS_READ_TOKENが必要です。非公開HarnessだけをContents: readで取得する専用設定で、値はGitHubの安全な設定先だけに入力します。設定作業は重複確認のうえTickTickへ登録済みです。設定後にCIの一連の成功とレビュー完了を確認してからマージします。未設定時の失敗をCI成功として扱いません。
計画:
docs/work/ci-validation/plan.md仕様:
docs/specs/ci-validation.md試験:
docs/tests/functional/ci-validation.md、docs/tests/unit/ci-harness-ref.md承認・対象外
会話でCI計画、専用参照権限、外部Actionの追加を承認済みです。先行するユーザー依頼によりPR作成・監視・問題がない場合のマージを行います。
新しい範囲外の指摘は現時点ではありません。forkへの検証提供、GitHub Appへの移行、定期監査、実DB・ブラウザ試験は今回に含みません。