Repository navigation
ci: run check-proof as an informational job - #31
Conversation
The test shards already run the golden replay suites, but a leaf root outside GOLDEN is only an xfail there, so a CPU-class mismatch never turns PR CI red. scripts/check-proof.sh fails on that xfail and on any unexpected skip; nothing ran it in CI. The job is continue-on-error: GOLDEN holds roots from the AMD dev host and the GitHub ubuntu-24.04 runner only, none from Blacksmith, and a GitHub-hosted run of one commit has already given two outcomes (see 730d248). Until the roots are shown to reproduce on this runner pool, a red gate must not fail ci or the images publish that calls it. It runs on blacksmith-8vcpu-ubuntu-2404 like the test job (founder choice over ubuntu-24.04), with the same setup steps and Runner CPU summary line, and uploads the tee'd output with the upload-artifact SHA already pinned in gpu-vast.yml and miner-flow.yml. Upload stays on failure() only: an upload on cancel would also fire on every superseded PR run, and the script bounds itself at its 600 s budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Run the proof check .github/workflows/ci.yml |
The workflow runs the proof script on Blacksmith Ubuntu 24.04 with a 15-minute timeout. It continues on error and uploads the log if a step fails. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Suggested reviewers: mathismassimino-hub
Merge Risk: 
7de37
-
The proof check is informational, and no issue requiring a fix before merge is established.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding an informational CI job to run check-proof. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Why
scripts/check-proof.sh(golden, codec, parity, trace, island; ~32 s) is not run in CI. GOLDEN roots have no Blacksmith-runner root yet, so the job is informational (continue-on-error: true) until one green run exists.What
.github/workflows/ci.ymlonly (+44): acheck-proofjob onblacksmith-8vcpu-ubuntu-2404, same install steps and pinned SHAs astest, read-only permissions, log artifact on failure.Evidence
check-proof.shpasses locally in 32.4 s; YAML loads.continue-on-errorjob must not blockciorimages.yml; to be observed on this PR), 2 minors.livrables/lens/2026-10-25_hypertrain-ci-check-proof.md.Risk / rollback
Job likely red on first run (no Blacksmith GOLDEN root). If it turns out to block
ci/images, revert this commit. Follow-up: make it blocking or remove it once GOLDEN has a root.🤖 Generated with Claude Code
Summary by CodeRabbit