Repository navigation
fix(flawfinder): name 2.0.16, the first version with --sarif - #212
Merged
Merged
Conversation
…warning and the comment Flawfinder writes SARIF since 2.0.16 (2021-05-31, per its ChangeLog). With an older 2.0.x, CoreTrace's --sarif fails, so the run ends incomplete.
…incomplete IKOS only gets C and C++ files, so a --static run on Python sources alone does not start it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreTrace's flawfinder warning and the comment beside it gave 2.0 as the minimum version, which is wrong: flawfinder added
--sarifin 2.0.16 (2021-05-31, per its ChangeLog). CoreTrace always passes--sarif, so with an older 2.0.x release flawfinder fails and the run ends incomplete.Changes
test:addsctrace_flawfinder_without_sarif_names_the_version_it_needs. It uses a flawfinder that prints no SARIF (/bin/echo) and checks that the warning names 2.0.16. Before the fix it failed, because the warning still said 2.0.fix(flawfinder):the warning and the comment now name 2.0.16.docs(changelog):corrects the Unreleased entry, which said that every--staticrun ends incomplete because of IKOS. Each tool only gets the files of its language (planJobs,IAnalysisTool::analyzes), so IKOS does not run on Python-only inputs. Only--staticruns on C or C++ sources end incomplete.The README states the same two things. It will be corrected by the README rewrite, which comes as a separate pull request.
Verification (macOS, LLVM 20, Python analyzer off)
ctest: 100/100 passed. The new test failed before the fix.scripts/format-check.shwith clang-format 20: passed.scripts/check-license-compliance.sh: passed.git diff --check: no whitespace errors.