Repository navigation
datagram@2: the default framing - #26
Merged
Merged
Conversation
- `WireFraming::Datagram2(number)` frames through the runtime's `Datagram2Framing`; the number is the protocol's position among every protocol in the project, as the generators give it. - The shape and the connection choice spell it `datagram@2`; `Auto` follows a protocol's resolved framing, which is now `datagram@2` unless it says otherwise. - The compare matrix runs datagram@2 with JSON and MessagePack too. - The chat fixture is on datagram@2, the default. - Pins runtime 4d6e1c5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25. Part of Stage 5 of the package wire defaults (proposal).
WireFraming::Datagram2(number)frames through the runtime'sDatagram2Framing:[kind][protocol varint][call_id][request_id][params], with replies tagged the same way. The number is the protocol's position among every protocol in the project, which is how the generators number it.Framing/FramingChoicegain"datagram@2".Autofollows the protocol's resolved framing. Once the playground passes core's injected framing through, that'sdatagram@2unless the protocol says otherwise.datagram@2/jsonanddatagram@2/msgpack, so it has 5 combos now. The playground's compare view lists whatever comes back.datagram@2, the default.Not here: a
packed@1codec. The simulator encodes untyped JSON values, andpacked@1has no tags or widths on the wire, so it needs an encoder driven by the schema's types. That's a follow-up.