Repository navigation
deps: core 2ae9986 (core#148) and generation's comline.toml config - #84
Merged
Merged
Conversation
Moves comline-core to 2ae9986 and comline-codegen/comline-conformance to generation de7ceb4 (comline.toml's config module and schema). core#148 gave unverified::cause the encoding declarations it judges with. A generate request carries none, so the doc comment passes the official ones only, which names the handshake's cause exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the core 2ae9986 cascade (generation#92).
comline-coremoves to2ae998634bad418e4a03ce7494e673275dafcc01in codegen and xtask.comline-codegenandcomline-conformancemove to generationde7ceb4c266d1fb5d6dc3c918d84cb226003f6b6(generation#92's first commit). That commit adds the comline.toml config module and the core re-pin.unverified::causethe encoding declarations it judges with. A generate request carries none, so the@unverifieddoc comment passesEncodings::default()(the official encodings only). For every existing schema it names the handshake's cause exactly as before.RUNTIME_REVis unchanged.cargo build,cargo test,xtask --checkand the wasm32-wasip1 generator build pass locally.cargo tree -dshows one copy of each comline crate.Merge after generation#92.