Repository navigation
conformance: move the runtime pin to conformance spec 0.2 - #114
Merged
Merged
Conversation
…decimal json compare Moves comline-runtime-conformance and the test reference to the runtime branch that adds spec 0.2 (handshake_check, the comline@1 profile) and reads 1 and 1.0 as the same number under compare: json (runtime#71). The reference test now expects the comline@1 handshake profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
comline-runtime-conformance(and the fixturecomline-reference) from runtime6f8f73ato4378c91, the head of runtime#72, which sits on top of runtime main's spec 0.2 (handshake_check, thecomline@1profile). Two effects:comline conformance --corpusloads a 0.2 corpus instead of failing withunknown variant handshake_check, socomline@1can be run through--impl.1and1.0are the same number undercompare: json.The graph stays on one runtime:
Cargo.lockholds a single runtime rev (comline-runtimeandcomline-runtime-conformance), and the fixture workspace moves with it.The reference test now also expects the
comline@1 (handshake)result, so it fails if a 0.2 corpus stops loading.Merge order: runtime#72 first, with a merge commit so
4378c91stays reachable on runtime main (a squash would orphan the pin).Ran
cargo fmt --check(also the conformance fixture), bothcargo clippy -D warningsconfigs, andcargo test.Closes #113