Skip to content

Router: requests to see profiles go to search - #14

Merged
CodexManvik merged 1 commit into
mainfrom
router-profile-requests
Nov 9, 2026
Merged

CodexManvik merged 1 commit into
mainfrom
router-profile-requests

Conversation

@CodexManvik

Copy link
Copy Markdown
Owner

What

The LLM router now treats a request to see or list profiles as a profile search, even when it names a place or a date.

Why

The benchmark run after Phase 4 (#13) scored 28/30. Both misses were bare requests such as "Profiles near Indonesia in January 2026", which the router sent to custom SQL. Before #13 the router sometimes ran out of tokens and fell back to keyword routing, which handles these correctly. With max_tokens=600 it now finishes, and the prompt never said such requests are searches.

The prompt's example ("Profiles off Sri Lanka in June 2026") is deliberately not a benchmark question. Summary tables ("Summarize the floats…") stay on SQL.

Checks

  • New unit test for the prompt rule; 103 unit tests pass; ruff clean.
  • After merge and deploy: re-run python -m eval against the live API and record the score in a follow-up PR.

🤖 Generated with Claude Code

With room to reason (max_tokens 600), the LLM router sent "Profiles near Indonesia
in January 2026" and "Profiles in the Bay of Bengal in September 2026" to custom SQL.
The prompt only said statistics go to SQL; it now says a request to see or list
profiles is a search even when it names a place or a date, with an example that is
not one of the benchmark questions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 05:03
@vercel

vercel Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
float-chat-ai Ready Ready Preview Nov 9, 2026 5:03am UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ada614c5-c84f-4cc4-b1a8-08198ad79fd4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@CodexManvik
CodexManvik merged commit 996c577 into main Nov 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants