Repository navigation
Conversation
Setting a non-empty allowed_names now emits a DeprecationWarning. The Citrine Platform ignores the field, and it will be removed in 4.0.0. The constructor argument, property, and JSON round-trip still work. The cake demo no longer sets the field. Bump the version to 3.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Citrine Platform no longer uses process-template allowed_names. Remove the constructor argument, the property, and the deprecation warning, along with their tests. JSON that still has the field loads, and the loader logs that it ignores the unexpected key. Bump the version to 4.0.0 for the breaking change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wjohnald
changed the title
4 of 8 tasks
wjohnald
marked this pull request as ready for review
November 12, 2026 14:22
Collaborator
|
Delete the attribute here would break all existing pipelines. I would much rather have a deprecation on 4.0 (which I was presuming would be dropping python 3.10 support) and then removal in 5.0. We'd presumably include a message about setting the attribute having no effect in the deprecation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEMD Python PR
Description
The Citrine Platform ignores
allowed_nameson process templates. It finds ingredient names from the ingredient specs. Epic PNE-9643 drops the field, so this PR removes it from GEMD Python.This PR breaks the public API. Code that passes or reads
allowed_namesfails with 4.0.0.This PR makes these changes:
allowed_namesfrom theProcessTemplateconstructor and its attributes.JSON that has the field loads in 4.0.0. The loader drops the field and logs a warning.
GEMD Python never checked ingredient names against
allowed_names. Every existing check stays in place.Run the checks in CONTRIBUTING.md to test it.
PR Type:
Adherence to team decisions
🤖 Generated with Claude Code