Repository navigation
Tolerate unknown ingestion error types - #1071
Merged
pacdaemon merged 1 commit intoNov 13, 2026
Merged
Conversation
pacdaemon
force-pushed
the
ingestion-error-type-fallback
branch
from
November 11, 2026 15:50
a1f1678 to
ecc7bdc
Compare
anoto-moniz
approved these changes
Nov 11, 2026
anoto-moniz
left a comment
anoto-moniz
left a comment
Collaborator
There was a problem hiding this comment.
Improving consistency is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
IngestionErrorTrace.error_typenow maps an error type the SDK doesn't know toIngestionErrorType.UNKNOWN_ERRORinstead of raisingValueError, soIngestion.status()still returns the error and itsmsgwhen the server adds a type before the SDK does. Only this field changes;properties.Enumerationstays strict for everything else. Follow-up to PNE-9739 and #1070.Stacked on #1070 (based on its branch, version bumped to 5.2.2 on top of its 5.2.1). PR checks only run against
main, so CI starts once #1070 merges and this retargets.PR Type:
Adherence to team decisions
🤖 Generated with Claude Code