Repository navigation
SEO: h1 on the lesson tools pages, spec follows #504 - #507
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tools/olfand/tools/olleach get one h1, from their layouts. Both pages render in the browser and their visible title is aPageHeader, which is not a heading. The title, description and canonical from Improve search titles, descriptions and structured data #504 are unchanged.@graph, and lesson titles read<lesson> | Free <program> Lesson.Evidence
seo.spec.ts› "a lesson describes itself as a learning resource…" fails: it looked for a top-levelLearningResourceand the old title format.Proof
Slot 5 (
BASE_URL=http://localhost:8501, with a temporary config that drops the global login setup, which these request-only tests do not need):src/app/tools,npx playwright test seo.spec.ts -g toolsgives 2 failed (h1 count 0, expected 1).npx playwright test seo.spec.tsgives 21 passed. Before the spec update, the lesson test failed withLearningResourceundefined.tsc --noEmitexits 0, and eslint is clean on the changed files.