Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_file_from_memory(..., filetype=FileType.SYMBOLINK_LINK, linkpath=...)writes a link with no target. The generic libarchive link setters update an existing link but do not initialize its link metadata; newly created hard links have the same problem.Use the explicit symbolic-link or hard-link setters according to the entry's file type, retaining the selected metadata codec. Apply a supplied file type before its target when constructing or modifying entries, so keyword order does not select the wrong link kind.
Fixes #143.
Validation: 12 regressions fail on master and pass with this change, alongside four passing preservation controls for parsed links, including UTF-8/Latin-1, bytes/text, target replacement, keyword order, native tar writers checked with
tarfile, and a raw CPIO newc header/payload check. The full suite passes 54 tests with one existing expected failure; Flake8 and wheel build pass (Python 3.12, libarchive 3.7.2).The configured forked/coverage suite also passes 54 tests/one expected failure with pytest 8.4.2. Current pytest 9.2.0 plus pytest-forked 1.7.5 fails in report serialization (
ValueError: unmarshallable object), including on clean master; plain pytest 9.2.0 passes. No dependency or CI configuration is changed.