Repository navigation
Guide: point the marching step at the Battle window - #97
Merged
Merged
Conversation
Pending attacks only show in the Battle window, so the guide's 'follow it in your logbook' sent new players to an empty list. The step's Show me button now opens the Battle window too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpWbfAaJDkWXoYYp9sFJo7
|
Preview: removed, this pull request is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Thijs · project thread
What
The guide step shown after the first attack (
s9marching) told players to follow the army in their logbook. Pending attacks don't show there; they show in the Battle window.s9marching.txt(en, nl, fr, pl): now points at the Battle window by its menu name (Battle / Oorlog / Bataille / Bitwa) and mentions that Show me opens it.Dolumar_Quests_S9BattleReport::getAction(): Show me opensbattle({'vid': …}, same as the attack step) instead oflogbook.There is no
deguide text, so nothing to change there. The step after the battle (s10clan) still says the report is in the logbook, which is true once the fight is over, so it is unchanged.Testing
php -lon the quest class. Text-only change otherwise; nl/fr/pl wording is mine and could use a native check.Generated by Claude Code