Repository navigation
#62 CR 1–4: brainstorming preferences and the superpowers-invocation guard - #64
Merged
Merged
Conversation
…on-trivial Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…he skill, not just SKILL.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…link, with the doctor hint Since CR 2's rglob, a dangling link scanned nothing and the guard passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
26 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #62. This is the first review round on #63 (
18deb3c..0312f7c), usingreviewing-code-python-fastapiwith a blanket--fix. There's one commit per finding.AGENTS.mdBrainstorming: v7's sizes don't replace the methodology. A "small change" that is non-trivial still gets a plan, and every change goes issue → branch → PR (38317fb)test_superpowers_invocations_resolve_herescans every*.mdin the skill, not onlySKILL.md: 36 references instead of 30, all resolving today (d276d7e)DOCTOR_HINT. Since CR 2, a dangling link globbed nothing and the guard passed on an empty scan. Withskills/executing-planspointed at a dangling target, it fails with('executing-plans', 'dangling: run \bash .skills/doctor.sh`')(57a74cb`)57fc8a3)Gate after the last fix:
ruff checkandruff format --checkclean, andpytestgives 697 passed, 14 skipped (environmental: production secrets aren't present in a worktree).No deploy: only
AGENTS.mdandtests/change.🤖 Generated with Claude Code