Repository navigation
Conversation
CallOfCreator
marked this pull request as draft
November 13, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localization update
and some minor things.
What I did
What's pending
The second wave of localization will be notification and event texts. All those scattered texts inside de Role/Role.cs files, since those require a little bit more attention.
My recommendations
Don't place text in any button. The text should be generated with the locale files. Hardcodding unnecessary leads to double text or unreadable messes.
Use MiraLocale for texts in the future, as it saves time for localizing the mod, or at least report the lack of strings so it can be worked on by me.
Avoid walls of text in general. It gets messy in-game and some languages (like Spanish) get even longer.
For localizing to other languages I recommend: Copy the en_us.xml and translate from there; and read my guide for translating / writing:
TEXT GUIDELINES (to avoid overflow and walls of text, and for localization purposes)
Intro Blurbs should be less than 42 characters (it overflows outside the screen).
Avoid using walls of text in MedDescription, this is used in the Role Settings and the wiki preview.
DO use [nl] or line breaks in TabDescription or Tab texts, because the tab will cover the WHOLE SCREEN if you don't.
WikiDescription is the text seen when you click a role icon in the new Mira API wiki.
When creating (or translating) settings or setting groups, avoid using long sentences, bc the text shrinks to use up the space and becomes unreadable.
PLEASE keep everything that's new in place or add it to the end of the document in the "Other" section so it can be moved later.