Repository navigation
(hardening) Authorize existing target trees before QuickTree writes - #43
Open
somethingwithproof wants to merge 2 commits into
Open
somethingwithproof wants to merge 2 commits into
somethingwithproof wants to merge 2 commits into
Conversation
somethingwithproof
force-pushed
the
fix/hardening-quicktree-auth-41
branch
from
October 17, 2026 19:54
80bdad8 to
6b9b8fa
Compare
somethingwithproof
force-pushed
the
fix/hardening-quicktree-auth-41
branch
2 times, most recently
from
October 17, 2026 19:58
8d8b765 to
59f58f2
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/hardening-quicktree-auth-41
branch
from
October 17, 2026 20:03
59f58f2 to
137b60b
Compare
TheWitness
requested changes
Oct 18, 2026
TheWitness
left a comment
TheWitness
left a comment
Member
There was a problem hiding this comment.
The function should be in includes/security.php and not in setup.php.
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuickTree currently writes headings and graphs into a request-selected tree without target authorization. Check visibility and the host ownership policy before any existing-tree write, for both ID and name lookups. On older hosts without the resource helper, allow only the owner or an administrator. Filter the tree selector with the same policy and reject invalid explicit IDs.
Validation: PHP 8.4.25 standalone regression, 9 owner/admin/view-denial/invalid-ID and newer-host-helper cases passed; syntax and diff checks passed.
Closes #41.