Repository navigation
(hardening) Protect QuickTree add and clear actions against CSRF - #42
Open
somethingwithproof wants to merge 3 commits into
Open
somethingwithproof wants to merge 3 commits into
somethingwithproof wants to merge 3 commits into
Conversation
somethingwithproof
force-pushed
the
fix/hardening-quicktree-csrf-40
branch
from
October 17, 2026 19:46
c0e3160 to
d43e106
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
fix/hardening-quicktree-csrf-40
branch
from
October 17, 2026 19:56
d43e106 to
cbb856b
Compare
TheWitness
requested changes
Oct 18, 2026
TheWitness
left a comment
TheWitness
left a comment
Member
There was a problem hiding this comment.
We keep doing this differently. I'm not entirely happy with the way it's done here.
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Member
Author
|
778a07d routes the add and clear checks through one named guard in |
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
Member
Author
|
Resolved the conflict with main in 6ed16a1, preserving both the named CSRF guard and the newly merged tree-authorization helper. The 23 mutation cases, four authorization cases and JavaScript POST test pass locally; hosted PHP 8.2, 8.3 and 8.4 integration and Sonar checks also pass. The requested consistency review remains open for your decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding or clearing queued graphs currently changes state through GET, including the bulk-action clear alias. Validate the effective action after remapping, require POST and a successful Cacti CSRF check, and send graph additions as JSON-response AJAX POST requests through the host CSRF-aware transport. The existing bulk clear form already submits by POST.
Validation: PHP 8.4.25 standalone regression, 16 direct/alias request cases passed; Node 22.22.2 client regression passed, including preserved graph fields and notifications; syntax and diff checks passed.
Closes #40.