Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…Apps Job - deploy.yml builds with docker/build-push-action, runs the migrate job on the new image, then deploys with azure/container-apps-deploy-action and waits for the revision to become ready. The smoke test, traffic pinning, and deactivate steps are gone (ADR-0014). - The web image only serves; migrations run once per deploy in the <app>-migrate job (ADR-0015, supersedes ADR-0013). - Spec, provisioning and rollback runbooks updated to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- migrate.sh: loop while the job execution is Running/Processing, pass only on Succeeded; the step's timeout-minutes bounds it. - wait-ready.sh: az resource wait paces the wait, then one az containerapp show decides — az resource wait exits 0 on timeout, so it can't. - deploy.md notes where the scripts live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both stages build from one base (openssl, telemetry off, /app), and the run stage's WORKDIR replaces the sh -c / cd / exec wrapper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ADR-0013 never reached main, so instead of a superseded record the migrate-job ADR (now 0014) carries its context (the runner can't reach Postgres) and lists migrate-at-start as the runner-up. The readiness-probe ADR is now 0013. References across docs, workflow, scripts and code follow the new numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/deploy