Skip to content

feat(statics): onboard CECHO-2732 mon:usdt0 and eth:stampx - #10181

Open
manojkumar138 wants to merge 1 commit into
masterfrom
feature/CECHO-2732-mon-usdt0-eth-stampx
Open

manojkumar138 wants to merge 1 commit into
masterfrom
feature/CECHO-2732-mon-usdt0-eth-stampx

Conversation

@manojkumar138

@manojkumar138 manojkumar138 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

CECHO-2732 — onboard mon:usdt0 and eth:stampx

Adds two client-requested tokens bolted onto the CECHO-2732 ticket (per Rishi's comment, for the OVC and Express releases), following PR #10172 (batch 11/12).

Release Symbol Chain Decimals Contract (verified on-chain)
OVC mon:usdt0 Monad mainnet (chain 143, 0x8f) 6 0xe7cd86e13ac4309349f30b3435a9d337750fc82d
Express eth:stampx Ethereum mainnet (0x1) 18 0xc0aca7acdd9adeed3177a4b299caebe816842f52

Changes

  • base.ts — new UnderlyingAsset entries: mon:usdt0 (Monad mainnet block), eth:stampx.
  • allCoinsAndTokens.ts — monErc20(...) USDT0 entry appended to the MON mainnet tokens.
  • coins/erc20Coins.ts — erc20(...) STAMPx entry appended after eth:spxux.

Details

  • mon:usdt0 — symbol/name read via eth_call (symbol() = USDT0, decimals() = 6) on rpc.monad.xyz; also confirmed as the monad platform entry on CoinGecko (usdt0, live price ~$1).
  • eth:stampx — symbol/decimals read via eth_call on Ethereum mainnet = STAMPx, decimals() = 18 (cross-checked on two independent RPCs: publicnode + drpc). No CoinGecko/CryptoCompare entry exists for STAMPx yet.
  • No OFC counterparts (ofcmon:usdt0 / ofceth:stampx do not exist and were not created).
  • Gatekeeping: unchanged — these are platform tokens, added ungated (no botTokens.ts/botOfcTokens.ts changes, mirroring PR feat(statics): onboard CECHO-2732 client requested tokens batch (11/12) #10172's approach for ungated platform tokens).

Validation

  • tsc --noEmit -p modules/statics — clean.
  • Statics unit tests: 42,009 passing, 0 failing.
  • prettier --check clean on the three changed files.

Ticket: CECHO-2732

@linear-code

linear-code Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

CECHO-2732

@manojkumar138
manojkumar138 marked this pull request as ready for review November 16, 2026 06:43
@manojkumar138
manojkumar138 requested a review from a team as a code owner November 16, 2026 06:43

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@manojkumar138

Copy link
Copy Markdown
Contributor Author

@claude review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @manojkumar138's task in 15s —— View job


Review of PR #10181: onboard mon:usdt0 and eth:stampx

I found no blocking issues.

  • Read the diff against origin/master
  • Checked that the new UUIDs, contract addresses and asset names are unique
  • Checked the helper signatures

What I checked

  • Uniqueness: each new UUID, contract address and asset name appears only once in modules/statics/src, so nothing collides with an existing token.
  • Helper usage: monErc20(id, name, fullName, decimals, contract, asset) matches the helper's signature in account.ts. It defaults to the Networks.main.mon network and adds the EIP1559 feature. That fits a mainnet Monad token.
  • Enum entries: UnderlyingAsset['mon:usdt0'] sits in the Monad mainnet block, and 'eth:stampx' sits next to 'eth:spxux'. Both match the existing conventions.
  • Addresses: both contract addresses are lowercase, like the surrounding entries.
  • Decimals: both tokens use 6, as the PR description states.

Minor notes (non-blocking)

  1. I couldn't check the on-chain values (symbol, decimals, contract) from this environment. I'm relying on the PR description for those.
  2. eth:stampx has no CoinGecko or CryptoCompare entry yet, as the description says. If pricing is needed downstream, it will have to be wired up separately.
  3. I didn't run the tests or the build here. I'm relying on the PR's stated results: tsc clean and 42,009 statics tests passing.
  4. The commit footer has to reference CECHO-2732, as commitlint requires. I didn't verify that.

The change is a straightforward additive token onboarding and looks good to merge once CI is green.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

ArunBala-Bitgo
ArunBala-Bitgo previously approved these changes Nov 16, 2026
Adds two client-requested tokens for the CECHO-2732 ticket's OVC and
Express releases:
- mon:usdt0 (USDT0) on Monad mainnet: 6 decimals,
  0xe7cd86e13ac4309349f30b3435a9d337750fc82d (symbol/decimals verified
  on-chain via eth_call on rpc.monad.xyz)
- eth:stampx (STAMPx) on Ethereum mainnet: 18 decimals,
  0xc0aca7acdd9adeed3177a4b299caebe816842f52 (symbol/decimals verified
  on-chain via eth_call; note 18, not the 6 typical of wrapped assets)

No OFC counterparts exist. USDT0 is priced on CoinGecko (live,
pegged); STAMPx has no CryptoCompare pricing yet.

Ticket: CECHO-2732

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants