Skip to content

fix: retry sibling publish and poll npm in release verify - #10179

Merged
danielpeng1 merged 1 commit into
masterfrom
WCN-4679-npmjs-release-retry-and-poll-npm
Nov 13, 2026
Merged

danielpeng1 merged 1 commit into
masterfrom
WCN-4679-npmjs-release-retry-and-poll-npm

Conversation

@danielpeng1

Copy link
Copy Markdown
Contributor

Make the stable npm release tolerate transient publish failures and npm propagation lag, so first runs stop needing a recovery-mode rerun.

  • Publish siblings (pass 1) now retries lerna publish from-package up to 3 times, 60s apart.
  • Before each retry, restore the package.json files lerna rewrote, so the next attempt doesn't fail with EUNCOMMIT.
  • Rename Verify recovery published the missing versions to Verify published versions are on npm, and run it on every non-dry-run release instead of only in recovery mode.
  • The verify step polls each public package's exact-version URL every 15s, up to a shared 10-minute deadline, instead of failing on the first 404. This includes bitgo.
  • A curl network error in the verify step now counts as "not visible yet" instead of aborting the step.
  • Not covered: a lerna failure in pass 2 (bitgo publish) and versions npm holds in a staged state still need a recovery run.

Ticket: WCN-4679

@danielpeng1 danielpeng1 self-assigned this Nov 13, 2026
@danielpeng1
danielpeng1 requested review from a team as code owners November 13, 2026 16:48

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

WCN-4679

@danielpeng1
danielpeng1 merged commit 52d9bfc into master Nov 13, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants