Repository navigation
Address #287 review: configurable browser prediction and evaluation - #289
Merged
martin-raden merged 2 commits intoOct 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the maintainer review on #287 by making the browser interface support both configurable IntaRNA prediction and IntaRNAeval structure evaluation, with vaRRI's institutional styling.
This PR depends on #287 and targets its
feat/286-wasm-webinterfacebranch so the diff contains only the requested review revisions.Changes
main-v2colors/header with local copies of the official group and university logos.CommandLineParsing.cpp; evaluation retains energy/accessibility settings and excludes prediction constraints. Include energy parameter sets/temperature, strand accessibility/regions, seed/helix settings, SHAPE data, windows and overlap/output filters.build-info.txt/JSON; display versions in the interface. Staging preserves compiled provenance and checks the paired assets.override. These C++ edits only change declarations. Emscripten rejects inconsistent missing overrides; third-party headers remain unchanged.Validation
-Wsuggest-override -Wsuggest-destructor-overridereports no missing overrides in IntaRNA headers.npm test --prefix webinterface: all 10 protocol/results/lifecycle groups passed.node scripts/wasm/smoke.mjs: original native-reference coordinates/energies, structured accessibility and C++ error handling passed.node scripts/wasm/smoke-protocol.mjs: real prediction/evaluation, signed coordinates, multi-FASTA/pairwise mode, all columns, imported accessibility, alternate energy/seed/helix/SHAPE settings and additional files passed.make tests -j3: all eight groups passed, including 462,689 assertions across 119 API cases. Tracked fixtures were linked into the separate build directory for the existing shell harness.git diff --check: passed.Browser scope
Up to 20 FASTA records per strand in prediction; evaluation accepts one query/target and up to 100 supplied structures. Records are 2–2,000 nt, with additional seed-length checks; selected sequence-pair length products total at most 1,000,000. Output count is 0–100 per pair, defaulting to the CLI's one. ASCII/detailed/ensemble reports each run a fresh engine instance, adding computation time. Local text inputs replace SHAPE/accessibility file paths; process-level options remain in the CLI. The base-pair maximization energy model is omitted as requested. Details and reproducible checks are in
webinterface/docs/.