Repository navigation
Plan per-seed output selection for #285 - #288
Closed
Alexander-Mitrofanov wants to merge 1 commit into
Closed
Alexander-Mitrofanov wants to merge 1 commit into
Alexander-Mitrofanov wants to merge 1 commit into
Conversation
Member
answers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #285.
This is a draft implementation checkpoint, following the issue's instruction to stop and ask in a PR when questions arise.
--outNumberPerSeedis not implemented yet.The source investigation found that shared ranking discards candidates before seed traceback, so filtering the final output would lose some seeds' best interactions. Model P also ranks site ensembles, which can disagree with both per-seed ensemble ranking and individual-conformation MFE ranking. Selecting an interpretation changes scientific results.
The new implementation plan records the relevant code paths, concrete examples, proposed scope, implementation steps and regression matrix. ChangeLog records this documentation checkpoint. Prediction behavior is unchanged.
Guidance needed
--noSeed, evaluation excluded, quotas shared across merged regions/windows and reset with--outPerRegion, then deduplication followed by final overlap/energy/count restrictions without refilling per-seed quotas?After guidance, the plan is to add a default-zero CLI/OutputConstraint field, collect eligible candidates before global pruning with explicit seed identity and coherent traceback, merge at the agreed scope, then validate against independent short-sequence oracles and the full release/debug suites. Zero must retain the existing execution path and outputs.
Validation of this checkpoint
git diff --checkpassed.master(2c4d0ec).Awaiting a review answer before implementation, as requested in #285.