[michaelthyregod]

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

• I have read the CONTRIBUTING document
• My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• Breaking change (fix or feature that would cause existing functionality to change)
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed (see below: three failures that were there before this change)

Description

Fixes #150, option (1): every module is loaded through AngleSharp's IResourceLoader, whatever its scheme.

• JsModuleLoader.LoadModuleContents no longer hands non-http(s) URLs to Jint's DefaultModuleLoader, which read them from the local disk.
• New: LoadModuleContentsAsBytes is overridden the same way. This was a second path to the disk, for import … with { type: 'bytes' }, which Jint's loader always served from the file system.
• Both share one fetch. A missing response (no requester for the scheme) is reported as an error instead of a NullReferenceException.
• Module resolution is unchanged.

Normal web use is unaffected: http/https modules already went through the resource loader, and all existing module tests pass. A host that loads modules from disk on purpose now registers a requester for file:. That's the only behaviour change.

Tests: EcmaTests.ModuleIsNotReadFromTheLocalDisk has 5 cases. A page at https://example.com/ tries to read a temporary local file through a direct specifier, an import map, import(), a .js module and a bytes module. All 5 fail without the change and pass with it.

Test runs (Windows 11, .NET SDK 10.0.403, the two classes that go online excluded):

• net10.0: 533/533 passed under the invariant culture (DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1).
• net462 and net472 (and net10.0 under the machine's own culture), the failures below are there without this change too:
  • NumbersAreGivenAsNumbers("decimal") and MethodOverloadFittingTheArgumentsIsCalled("overloaded([1.5, 2])") fail under a culture with a decimal comma, such as en-DK, because the tests format the result with the current culture.
  • CrossOriginTests.MessageReachesAFrameOfAnotherOriginWithWhoSentIt is intermittent (here on net462 and net472). I've found the cause and will report it separately.

All library targets build with 0 warnings.

Not in this PR, on purpose: FetchModule still blocks on .Task.Result and doesn't check the response status. Happy to follow up on those separately if you want.

🤖 Generated with Claude Code

[CLAassistant]

All committers have signed the CLA.

[FlorianRappl]

LGTM!

[FlorianRappl]

LGTM!