Skip to content

Synchronize cross-origin message assertions - #149

Merged
FlorianRappl merged 2 commits into
develfrom
copilot/fix-windows-github-actions-job
Nov 3, 2026
Merged

FlorianRappl merged 2 commits into
develfrom
copilot/fix-windows-github-actions-job

Conversation

Copilot AI commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The Windows Actions job failed on .NET Framework 4.7.2 because the cross-origin messaging test could observe the reply before its origin was available.

  • Test synchronization: Wait for both the reply data and replyOrigin before asserting the message origin.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: FlorianRappl <1766191+FlorianRappl@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'windows' Synchronize cross-origin message assertions Nov 3, 2026
Copilot AI requested a review from FlorianRappl November 3, 2026 13:09

@FlorianRappl FlorianRappl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianRappl
FlorianRappl marked this pull request as ready for review November 3, 2026 13:17
@FlorianRappl FlorianRappl added this to the v1.2.0 milestone Nov 3, 2026
@FlorianRappl
FlorianRappl merged commit 1ef6b07 into devel Nov 3, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants