Skip to content

[PWGCF] add manual ck calculations - #18342

Open
Luzhiyongg wants to merge 6 commits into
AliceO2Group:masterfrom
Luzhiyongg:master
Open

Luzhiyongg wants to merge 6 commits into
AliceO2Group:masterfrom
Luzhiyongg:master

Conversation

@Luzhiyongg

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 18, 2026
@github-actions github-actions Bot changed the title add manual ck calculations [PWGCF] add manual ck calculations Oct 18, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 6 warnings, 🔕 5 disabled

[PWGCF] Please consider the following formatting changes to AliceO2Group#18342
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0a07989 at 2026-10-18 11:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 195 warnings.'
Found 1 errors and 195 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/592fd449aa4cffb1a0ba7390d42fd047be3f1e30/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTask.cxx:1122:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
++ [[ 195 -gt 0 ]]
++ cat /sw/BUILD/592fd449aa4cffb1a0ba7390d42fd047be3f1e30/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTask.cxx:82:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Flow/Tasks/flowTask.cxx:83:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:84:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:86:8: warning: constructor does not initialize these fields: ccdb, fPtAxis, gCurrentHadronicRate, hFindPtBin, funcV2, funcV3, funcV4 [cppcoreguidelines-pro-type-member-init]
PWGCF/Flow/Tasks/flowTask.cxx:101:66: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:103:67: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:367:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:462:22: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:482:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTask.cxx:489:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:491:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:493:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:499:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:506:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:513:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:529:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:541:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:655:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:655:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:658:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:658:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:672:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:674:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:679:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:689:111: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/flowTask.cxx:694:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:696:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:699:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:710:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:712:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:715:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:717:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:720:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b4ca88b at 2026-10-18 11:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 187 warnings.'
Found 1 errors and 187 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/5e4f73447f0c025ebf9ef3a648142d0012fe47da/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/flowTask.cxx:1122:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
++ [[ 187 -gt 0 ]]
++ cat /sw/BUILD/5e4f73447f0c025ebf9ef3a648142d0012fe47da/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/flowTask.cxx:82:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/Flow/Tasks/flowTask.cxx:83:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:84:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:86:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Flow/Tasks/flowTask.cxx:101:66: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:103:67: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGCF/Flow/Tasks/flowTask.cxx:367:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/Flow/Tasks/flowTask.cxx:462:22: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:482:5: warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
PWGCF/Flow/Tasks/flowTask.cxx:489:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:491:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:493:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:499:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:506:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:513:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:529:51: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:541:63: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:655:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:655:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:658:59: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:658:92: warning: redundant call to 'c_str' [readability-redundant-string-cstr]
PWGCF/Flow/Tasks/flowTask.cxx:672:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:674:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:679:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:689:111: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGCF/Flow/Tasks/flowTask.cxx:694:49: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:696:11: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:699:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Flow/Tasks/flowTask.cxx:710:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:712:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:715:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:717:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/Flow/Tasks/flowTask.cxx:720:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants