Skip to content

[PWGLF] New histograms for systematics calculation - #18341

Merged
abmodak merged 5 commits into
AliceO2Group:masterfrom
tutripat:master
Oct 17, 2026
Merged

abmodak merged 5 commits into
AliceO2Group:masterfrom
tutripat:master

Conversation

@tutripat

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Oct 17, 2026
@github-actions github-actions Bot changed the title New histograms for systematics calculation [PWGLF] New histograms for systematics calculation Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#18341
Removed redundant comments and cleaned up code structure.
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9e694b3 at 2026-10-17 19:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/5eea65673f8fa9f8035f50e531c3499dbceb03e8/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:704:39: error: no header providing "THnSparse" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2806:5: error: no header providing "UChar_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/5eea65673f8fa9f8035f50e531c3499dbceb03e8/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:100:10: warning: variable 'recoTruthStatusAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2281:14: warning: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2608:14: warning: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2701:40: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2805:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2806:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2807:37: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2864:17: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2876:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2878:34: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 40c42bf at 2026-10-17 19:32:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 10 warnings.'
Found 2 errors and 10 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/4a4e84f2fd3b8a610e3f2f20943a8b66d32acd47/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:704:39: error: no header providing "THnSparse" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2806:5: error: no header providing "UChar_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/4a4e84f2fd3b8a610e3f2f20943a8b66d32acd47/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:100:10: warning: variable 'recoTruthStatusAxis' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2281:14: warning: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2608:14: warning: constructor does not initialize these fields: bit [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2701:40: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2805:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2806:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2807:37: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2864:17: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2876:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/PseudorapidityDensityMFT.cxx:2878:34: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@abmodak
abmodak merged commit 143192a into AliceO2Group:master Oct 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants