Skip to content

Fix muted unlocking while deploying only k8s tasks #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justonedev1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix muted unlocking while deploying only k8s tasks #864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/task/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,14 +540,13 @@ func (m *Manager) acquireTasks(envId uid.ID, taskDescriptors Descriptors) (err e
copy(tasksToRunThisAttempt, tasksToRun)

allDeployedTasks := make(DeploymentMap)
m.deployMu.Lock()
if len(tasksToRun) > 0 {
// Alright, so we have some descriptors whose requirements should be met with
// new Tasks we're about to deploy here.
// First we ask Mesos to revive offers and block until done, then upon receiving
// the offers, we ask Mesos to run the required roles - if any.

m.deployMu.Lock()

DEPLOYMENT_ATTEMPTS_LOOP:
for attemptCount := 0; attemptCount < MAX_ATTEMPTS_PER_DEPLOY_REQUEST; attemptCount++ {
// We loop through the deployment attempts until we either succeed or
Expand Down
Loading