Repository navigation
Fix PyPI publish workflow, 100% coverage, aggregate option fix - #155
Merged
Merged
Conversation
- publish workflow: use pypa/gh-action-pypi-publish@release/v1 (the pinned old action rejected the package's metadata version 2.5), build + twine check first - fix: aggregate options were passed as max_time_ms/allow_disk_use and rejected by MongoDB; now maxTimeMS/allowDiskUse/batchSize - fix: missing annotation values hydrate as None; dangling references keep their id in fetch_related - remove unreachable branches and dead helpers - tests: ~150 new tests, line + branch coverage 100%; Django test settings centralised in tests/contrib/conftest.py (no pytest-django needed) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
============================================
+ Coverage 83.87% 100.00% +16.12%
============================================
Files 29 29
Lines 4819 4802 -17
Branches 849 838 -11
============================================
+ Hits 4042 4802 +760
+ Misses 512 0 -512
+ Partials 265 0 -265 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ation) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.0 release workflow failed: the pinned
gh-action-pypi-publishrejects metadata version 2.5 (nothing was uploaded to PyPI).pypa/gh-action-pypi-publish@release/v1and runstwine checkfirstdefault_max_time_ms,options(max_time_ms=..., allow_disk_use=...)) used the wrong option namesNone, dangling references keep their idAfter merge: re-create the
v1.0.0release from the newmaincommit to publish to PyPI.🤖 Generated with Claude Code