Repository navigation
A number's conjugate is made under the setting in force - #2192
Merged
Rafael-SOWNet merged 1 commit intoOct 28, 2026
Merged
Rafael-SOWNet merged 1 commit into
Rafael-SOWNet merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2192 +/- ##
==========================================
- Coverage 86.54% 86.54% -0.01%
==========================================
Files 297 297
Lines 66324 66324
Branches 19267 19267
==========================================
- Hits 57402 57400 -2
Misses 4852 4852
- Partials 4070 4072 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Complex.Conjugate was kept on the instance, made by Complex.Create under whatever downcasting setting its first caller had. A division by a complex number conjugates the divisor, so a division by i with the downcasting off left 0 - 1i, in decimals, as the conjugate of Complex.ImaginaryOne, the one instance every i is. conj(i) was that for every caller after it, in every thread. Two tests on #2190's branch failed in the full suite and passed alone: conj(i) against -i, and MathS.Conjugate's documented example. Which ran first decided it. The conjugate is now made each time it is asked for, under the setting in force, as every other number is: the division that asks for it reads the modulus the same way (#1615). A regression test divides by i with the downcasting off first; it fails without the change, with 0 - 1i. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Rafael-SOWNet
force-pushed
the
a-numbers-conjugate-is-made-under-the-settings-in-force
branch
from
October 28, 2026 22:23
024130f to
97596b8
Compare
Rafael-SOWNet
deleted the
a-numbers-conjugate-is-made-under-the-settings-in-force
branch
October 29, 2026 00:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex.Conjugatewas cached on the instance, and built byComplex.Createunder the downcasting setting of its first caller. A complex division conjugates its divisor. So one division byiwith downcasting off left0 - 1i, in decimals, as the conjugate ofComplex.ImaginaryOne, the instance everyiis. Every later caller, in every thread, got that value.On #2190, two tests failed in the full suite and passed alone:
conj(i)against-i, and the documented example ofMathS.Conjugate. Whichever test ran first decided the outcome.The conjugate is now built each time it is asked for, under the setting in force, as every other number is.
Complex.ImaginaryOne.Conjugate, after(1 / Complex.ImaginaryOne).EvaledwithDowncastingEnabledoff0 - 1i-iThe regression test divides by
iwith downcasting off before it conjugates. Without the change it fails with0 - 1i.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura