Repository navigation
A conjunct of a condition that another conjunct forces is not stated - #2186
Merged
Rafael-SOWNet merged 1 commit intoOct 28, 2026
Merged
Conversation
(sqrt(x) = a) provided a > -5 was solved to a ^ 2 provided a > -5 and a >= 0, and a >= 0
forces a > -5. When Providedf joins conditions, and in a condition written as a conjunction, a
conjunct that another conjunct forces is now dropped, which PredicateEntailment decides for
comparisons against numbers. A conjunct stated twice forces itself, so this also covers the
repeated condition dropped before; of two that force each other the first is kept. The
conjunction is rebuilt only where something goes, so every other condition keeps its shape.
(sqrt(x) = a) provided a > -5 { a ^ 2 provided a >= 0 }
x provided a > 1 and a > 2 x provided a > 2
(x provided a > 0) provided a >= 0 x provided a > 0
Part of #212.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
+ Coverage 86.45% 86.46% +0.01%
==========================================
Files 297 297
Lines 65448 65455 +7
Branches 19215 19218 +3
==========================================
+ Hits 56582 56595 +13
+ Misses 4808 4804 -4
+ Partials 4058 4056 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Oct 28, 2026
Rafael-SOWNet
deleted the
a-condition-entailed-by-another-is-not-stated
branch
October 28, 2026 19:21
Rafael-SOWNet
added a commit
that referenced
this pull request
Oct 28, 2026
An operation on two operands that each carry a condition joined the two with a bare and, so (a provided b > 0) + (c provided b > 0) was a + c provided b > 0 and b > 0, and a second derivative of 1/sqrt(x^2 + 13) stated not x ^ 2 + 13 = 0 three times. #2186 made Providedf.Both state a conjunct once where another conjunct forces it, and Providedf's own simplification goes through it. The join of two operands now does too, in ExpandOnTwoArguments and ExpandOnTwoAndTArguments, so the condition comes out as Providedf would state it. Part of #212. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happypig375 on #2183: "Some solutions like
{ a ^ 2 provided a > -5 and a >= 0 }obviously needs improvement - the conditions can be merged." Herea >= 0forcesa > -5, so the condition isa >= 0.When
Providedfjoins conditions, and in a condition written as a conjunction, a conjunct that another conjunct of the same condition forces is now dropped.PredicateEntailmentdecides that for comparisons against numbers. A conjunct stated twice forces itself, so this covers the repeated condition #2183 dropped as well. Of two that force each other, the first is kept, and the conjunction is rebuilt only where something goes, so every other condition keeps its shape.(sqrt(x) = a) provided a > -5, solved{ a ^ 2 provided a > -5 }(... and a >= 0on master){ a ^ 2 provided a >= 0 }x provided a > 1 and a > 2x provided a > 1 and a > 2x provided a > 2(x provided a > 0) provided a >= 0x provided a >= 0 and a > 0x provided a > 0x provided a > 0 and b > 0andx provided a > 0 and a < 5keep both conjuncts, in the order written. The rows are in #2183's breaking entry, which is not released yet.Measured
Part of #212.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura