From a05a103034ec64bb083e2ab66a83dcb4c2814695 Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Mon, 12 Oct 2026 10:06:23 -0500 Subject: [PATCH] Record review verdicts and counts, not sessions The Review line named a cross-review session id. That id names a file in the authoring worktree, which is deleted after merge, so no reader could open it. The service, Skills, and CLI now record the reviewer, the verdict, and the finding counts instead, and a material finding gets one line in the commit message, where git blame keeps it. The three CONTRIBUTING pages share this rule. --- .github/pull_request_template.md | 2 +- AGENTS.md | 2 +- CONTRIBUTING.md | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d590bcb..7abea80 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,7 +6,7 @@ Docs: diff --git a/AGENTS.md b/AGENTS.md index 8e93495..70089af 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -14,7 +14,7 @@ handled-error recovery in `docs/errors.md`, publication mechanics in `RELEASING. exit statuses, `AGENTS.md`, `CLAUDE.md`, `CONTRIBUTING.md`, `RELEASING.md`, `.claude/settings.json`, or `.codex/config.toml` get an independent review through cross-review: `codex-review` from Claude Code, `$claude-review` from Codex. Pass the service repository's `docs/review-focus.md` as `--focus-file` (see - `CONTRIBUTING.md`). Put the reviewer, session id, and verdict in the pull request body, and leave the findings out. + `CONTRIBUTING.md`). Put the reviewer, verdict, and finding counts in the pull request body, not the findings. - `firstdraft plan compile` defaults to local output in the current directory. GitHub publication requires `--github`; Codespaces is a fallback. Keep Skill callers and recovery instructions aligned with this boundary. - The service repository coordinates releases and owns their approval and smoke policy. One approved coordinated diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ba3373f..8fe5e49 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,8 +40,9 @@ that a bot such as Dependabot opens. The body also carries: - a summary of what changed and why; and -- when [AGENTS.md](AGENTS.md) requires independent review, one line, `Review: , session , `, - with the findings left out. +- when [AGENTS.md](AGENTS.md) requires independent review, one line with the reviewer, the verdict, and the counts, + such as `Review: Codex, approve (2 rounds, 3 findings fixed)`. Leave out session ids, which name files in a deleted + worktree, and the findings themselves; give a material finding one line in the commit message. Use GitHub closing keywords only for completed Issues: even `does not close #123` closes #123. Say the remainder is tracked in open Issue #123 instead. The [pull request template](.github/pull_request_template.md) holds these fields.