From 7e933da61901682cd8330297219adce4d3e3c8c0 Mon Sep 17 00:00:00 2001 From: Joe Orton Date: Fri, 16 Oct 2026 18:40:16 +0100 Subject: [PATCH 1/2] Fix h2ws test client option parsing on unsigned-char platforms: * test/clients/h2ws.c (main): Use int for the getopt() return value; with unsigned char (e.g. on aarch64) the -1 terminator is never matched, so every invocation failed with "invalid option". Co-Authored-By: Claude Fable 5 --- test/clients/h2ws.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/clients/h2ws.c b/test/clients/h2ws.c index 309348944ba..26864405ca2 100644 --- a/test/clients/h2ws.c +++ b/test/clients/h2ws.c @@ -973,7 +973,7 @@ int main(int argc, char *argv[]) struct uri uri; struct h2_session session; struct ws_stream *stream; - char ch; + int ch; cmd = argv[0]; while((ch = getopt(argc, argv, "c:vh")) != -1) { From 4ae7587e94bddde2a06192dd90587b3459720f26 Mon Sep 17 00:00:00 2001 From: Joe Orton Date: Fri, 16 Oct 2026 19:21:29 +0100 Subject: [PATCH 2/2] CI: Run the full pytest suite on 64-bit ARM: * .github/workflows/linux.yml: Add a "Python pytest test suites, 64-bit ARM" job to the matrix, as the existing pytest job but on the ubuntu-24.04-arm runner. Co-Authored-By: Claude Fable 5 --- .github/workflows/linux.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index b412dffea17..197d626ec79 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -144,6 +144,19 @@ jobs: TEST_PYTEST=1 TEST_MD=1 # ------------------------------------------------------------------------- + # As above, on a 64-bit ARM runner. + - name: Python pytest test suites, 64-bit ARM + config: --enable-mods-shared=reallyall --with-mpm=event --enable-mpms-shared=all + os: ubuntu-24.04-arm + pkgs: nghttp2-client + env: | + APR_VERSION=1.7.6 + APU_VERSION=1.6.5 + APU_CONFIG="--with-crypto" + NO_TEST_FRAMEWORK=1 + TEST_PYTEST=1 + TEST_MD=1 + # ------------------------------------------------------------------------- # Test against a newer nghttp2 than in the Ubuntu images. - name: mod_http2 w/nghttp2 1.68.0 config: --enable-mods-shared=reallyall --enable-maintainer-mode --with-mpm=event